Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Improve clarity and style of ResourcePicker menu #88435

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Feb 17, 2024

  • Adds ellipses to options opening a new menu
  • Adds a descriptive tooltip to Quick Load

Tooltip text is WIP, any suggestions for improvements are welcome!

Other tooltips could be added as well, or if it's too obstructive I can remove it too, the intent of it was to help with confusion over what it does, while acknowledging that no naming of the option can be 100% clear to everyone (And my opinion being that "Quick Load" is the most descriptive and correct wording)

Regardless of the decision on the tooltip this will add the appropriate ellipses as per the convention

Alternative to:


@AThousandShips AThousandShips added this to the 4.x milestone Feb 17, 2024
@AThousandShips AThousandShips requested review from a team February 17, 2024 13:24
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I brought up the ellipses yesterday in RocketChat so of course I am okay with it.

editor/editor_resource_picker.cpp Outdated Show resolved Hide resolved
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Feb 17, 2024
* Adds ellipses to options opening a new menu
* Adds a descriptive tooltip to `Quick Load`
@akien-mga akien-mga merged commit bc45802 into godotengine:master Feb 18, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename 'Quick Load' to 'Search'
4 participants